Cluster Display integration#1
Merged
Merged
Conversation
FrederickUnity
approved these changes
Nov 10, 2022
Collaborator
FrederickUnity
left a comment
FrederickUnity
left a comment
There was a problem hiding this comment.
See comments made while reviewing the different commits.
| } | ||
|
|
||
| static List<Texture2D> s_ScratchTextures = new (); | ||
| static readonly List<Texture2D> k_ScratchTextures = new (); |
Collaborator
There was a problem hiding this comment.
Curiosity: Is k_ for anything readonly or only for const or variables pointig to objects that shouldn't in theory change value?
Owner
Author
There was a problem hiding this comment.
This is what Rider suggested, but I must admit it doesn't make a lot of sense semantically.
wenzhang-unity
force-pushed
the
unity/cluster-display-integration
branch
from
c653c85 to
b827e65
Compare
Fix up some initialization logic. Refactoring: DRY, cleaner cluster handling logic
FrederickUnity
approved these changes
Nov 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to leverage lock-step execution of the Cluster Display package. This integration enables a wider range of multi-node rendering scenarios:
The integration uses the controller/follower setup in the RenderStream API.
Additional changes:
To Reviews: