Separate assembly for pipeline abstraction#15
Merged
Conversation
wenzhang-unity
requested changes
Mar 6, 2023
| /// Copies a camera's depth into a texture. | ||
| /// </summary> | ||
| class DepthCopy | ||
| public class DepthCopy |
Owner
There was a problem hiding this comment.
With this new assembly separation, you don't have to make any of the classes public. You can just use the InternalsVisibleTo attribute in the Diguise.RenderStream assembly.
…Unity into mark/separate-assemblies # Conflicts: # DisguiseUnityRenderStream/Runtime/Disguise.RenderStream.asmdef # DisguiseUnityRenderStream/Runtime/PipelineAbstraction/Presenter.cs
mark-beiline
commented
Mar 16, 2023
| "name": "Disguise.RenderStream.Editor", | ||
| "references": [ | ||
| "Disguise.RenderStream", | ||
| "Disguise.RenderStream.PipelineAbstraction", |
Collaborator
Author
There was a problem hiding this comment.
This is only for the AddAlwaysIncludedShader calls in DisguiseRenderStreamBuildPreProcessor.OnPreprocessBuild.
wenzhang-unity
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for the split: