Skip to content

Package structure#26

Merged
mark-beiline merged 7 commits into
devfrom
mark/package-structure
Apr 25, 2023
Merged

Package structure#26
mark-beiline merged 7 commits into
devfrom
mark/package-structure

Conversation

@mark-beiline
Copy link
Copy Markdown
Collaborator

  • Updated README.md
  • Added package.json file

image

Copy link
Copy Markdown
Collaborator

@FrederickUnity FrederickUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since my knowledge of packages is 0, wait for Wen's feedback before commit :)

Comment thread package.json Outdated
"name": "com.disguise.renderstream",
"displayName": "Disguise RenderStream",
"version": "1.0.0",
"unity": "2023.2",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the minimal version? Is 2023.2 released yet?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 2022.2.6f1 which I've used a lot during dev with no issues. If we go too far back (ex 2022.2.0b16) some of the API is missing so I'll keep it at 6f1 for now.

Copy link
Copy Markdown
Owner

@wenzhang-unity wenzhang-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mark-beiline mark-beiline merged commit 274318b into dev Apr 25, 2023
@mark-beiline mark-beiline deleted the mark/package-structure branch April 25, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants