Indexing fix for debug presenter#33
Merged
Merged
Conversation
FrederickUnity
approved these changes
May 3, 2023
|
|
||
| GameObject[] m_Cameras = { }; | ||
| ManagedSchema m_Schema = new (); | ||
|
|
Collaborator
There was a problem hiding this comment.
Minor / Preference: I'm not a big fan of tuple because it creates super long typenames that need to be fixed a little bit everywhere in the code whenever we add / remove something in it. This is why I instead prefer a simple struct...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the insight from PR #29 with a schema-based approach to make it compatible with #27.
Cleanup in DisguiseRenderStream.cs along the way:
Streamsandm_Cameraslists (they were 1-to-1) +CameraCaptureobjects. All 3 objects were already being created together inCreateStreams()for each stream.