Codex-generated pull request#2
Merged
weroperking merged 4 commits intomainfrom Feb 17, 2026
Merged
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdds a BetterBase monorepo scaffold: docs, workspace and TypeScript configs, a minimal CLI, and a Bun+TypeScript+Hono+Drizzle base template including env validation, routes, SQLite schema, and drizzle config. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant App as Hono App
participant Validation as Validation (Zod)
participant DB as Drizzle/SQLite
participant Error as Error Handler
Client->>App: POST /users { body }
App->>Validation: parseBody(createUserSchema, body)
Validation-->>App: validatedUser
App->>DB: insert user into users table
DB-->>App: insert result
App-->>Client: 201 { message, user }
Note right of Error: onError handles HTTPException or 500
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (8)
betterbase/apps/dashboard/README.md (1)
1-3: LGTM for a scaffold, but consider adding optional structure for future development.The minimal README is appropriate for a scaffold placeholder. The explicit "(Scaffold)" label and "Future" designation make the intent clear.
If you'd like to provide more guidance for future development, consider optionally adding:
- Planned features or purpose of the dashboard
- Technology stack (e.g., frameworks, libraries)
- Basic setup instructions placeholder
- Links to related documentation or design docs
📝 Optional enhancement example
# Dashboard App (Scaffold) Future BetterBase dashboard/studio app. + +## Purpose + +This will be the main dashboard/studio interface for managing BetterBase projects. + +## Planned Tech Stack + +- Framework: TBD +- UI Components: TBD +- State Management: TBD + +## Getting Started + +_Setup instructions will be added once implementation begins._🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/apps/dashboard/README.md` around lines 1 - 3, Update the README under the "Dashboard App (Scaffold)" heading to include an optional scaffolded structure for future development: add a short "Planned Features" list, a "Tech Stack" section naming frameworks/libraries, a "Setup" placeholder with basic steps or commands, and a "Related Docs / Links" section for design docs or tickets; keep these as optional bullet placeholders so maintainers can easily expand them later.betterbase/templates/base/tsconfig.json (1)
1-21: This config should extend../../tsconfig.base.jsonto avoid duplication and pick up shared settings.The root
tsconfig.base.jsonincludesisolatedModules,forceConsistentCasingInFileNames, and the@/*path alias, none of which are inherited here. The CLI'stsconfig.jsonalready extends the base — this template should follow the same pattern.Also,
noImplicitAny(Line 7) is redundant whenstrictis alreadytrue.♻️ Proposed fix
{ + "extends": "../../tsconfig.base.json", "compilerOptions": { - "target": "ES2022", - "module": "ESNext", - "moduleResolution": "Bundler", - "strict": true, - "noImplicitAny": true, - "esModuleInterop": true, - "skipLibCheck": true, - "resolveJsonModule": true, "types": [ "bun" ], "outDir": "dist" }, "include": [ "src/**/*.ts", "drizzle.config.ts", "betterbase.config.ts" ] }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/tsconfig.json` around lines 1 - 21, Update this tsconfig.json to extend "../../tsconfig.base.json" so it inherits shared options (like isolatedModules, forceConsistentCasingInFileNames and the `@/`* path alias) instead of duplicating them; remove the redundant "noImplicitAny" entry under "compilerOptions" (since "strict": true already covers it) and keep the template-specific overrides (e.g., "target", "module", "moduleResolution", "types", "outDir" and the "include" array) so local settings remain intact while shared settings come from the base.betterbase/tsconfig.base.json (1)
6-7: Nit:noImplicitAnyis redundant whenstrictis enabled.
strict: truealready enablesnoImplicitAny. Same applies to the template tsconfig.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/tsconfig.base.json` around lines 6 - 7, The tsconfig currently sets both "strict": true and "noImplicitAny": true which is redundant; remove the explicit "noImplicitAny" entry from the base tsconfig (and the template tsconfig) so that "strict": true governs the setting; update any comments if present to note that strict enables noImplicitAny and run a quick TypeScript build to confirm no behavior change.betterbase/templates/base/src/db/index.ts (1)
1-6: Pass the schema todrizzle()to enable relational queries and full type inference.Without passing
schema, you lose Drizzle's relational query builder (db.query.users...) and some type inference benefits.♻️ Proposed fix
import { Database } from 'bun:sqlite'; import { drizzle } from 'drizzle-orm/bun-sqlite'; +import * as schema from './schema'; const sqlite = new Database('local.db'); -export const db = drizzle(sqlite); +export const db = drizzle(sqlite, { schema });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/src/db/index.ts` around lines 1 - 6, The current call drizzle(sqlite) omits the schema so Drizzle cannot provide relational query builders or full type inference; update the module to import your generated/defined schema (e.g., import { schema } from './schema' or the file where your tables/types are defined) and pass it into drizzle as drizzle(sqlite, { schema }) so exports like db (and usages such as db.query.users) gain relational helpers and proper typings; keep the existing sqlite Database instantiation and export name db.betterbase/templates/base/src/middleware/validation.ts (2)
8-11:createUserSchemais unused — ensure it's wired to a route or remove it.This schema is defined but no route or handler in the current codebase consumes it. If it's intentional scaffolding for a future user-creation endpoint, that's fine — just flag it as a placeholder so it doesn't become forgotten dead code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/src/middleware/validation.ts` around lines 8 - 11, createUserSchema is defined but not used; either remove it or wire it into the user-creation flow — if it's intended scaffolding, mark it explicitly as a placeholder. To fix: if keeping, add a clear TODO comment above createUserSchema stating it's a placeholder and then import and use createUserSchema in your user route handler (e.g., call createUserSchema.parse(req.body) or safeParse in the createUser/createUserHandler function) so the linter sees it used; otherwise delete the createUserSchema export to avoid dead code.
4-6:parseBodythrows rawZodError— consider a Hono-friendly error middleware or wrapper.
schema.parse()throws aZodErroron invalid input. Without a global HonoonErrorhandler, this will surface as an unformatted 500 to the client. Consider wrapping withschema.safeParse()and returning a structured 400 response, or adding a global error handler that catchesZodError.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/src/middleware/validation.ts` around lines 4 - 6, parseBody currently calls schema.parse which throws a raw ZodError; change it to validate using schema.safeParse inside parseBody (or provide a Hono middleware wrapper) and when validation fails return/throw a Hono-friendly 400 response payload containing the validation errors instead of propagating the raw ZodError. Update the parseBody<T>(schema: ZodType<T>, body: unknown) implementation to call schema.safeParse(body), check result.success, and map result.error.issues into a structured error object (or throw a custom HttpError/Response) so callers receive a formatted 400 rather than an unhandled 500.betterbase/templates/base/src/db/schema.ts (1)
3-7: Consider addingcreatedAt/updatedAttimestamp columns.Most user tables benefit from audit timestamps. Since this is a starter template that others will clone, including them sets a good baseline pattern.
♻️ Proposed addition
+import { integer, sqliteTable, text, int } from 'drizzle-orm/sqlite-core'; +import { sql } from 'drizzle-orm'; + export const users = sqliteTable('users', { id: integer('id').primaryKey({ autoIncrement: true }), email: text('email').notNull().unique(), name: text('name').notNull(), + createdAt: integer('created_at', { mode: 'timestamp' }) + .notNull() + .default(sql`(unixepoch())`), + updatedAt: integer('updated_at', { mode: 'timestamp' }) + .notNull() + .default(sql`(unixepoch())`), });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/src/db/schema.ts` around lines 3 - 7, Add audit timestamps to the users table by extending the existing sqliteTable('users', ...) schema: add createdAt and updatedAt columns (e.g., timestamp/datetime or integer epoch) with createdAt defaulting to the current timestamp and updatedAt defaulting to the current timestamp as well; ensure updatedAt is set/updated on record updates (either via a DB trigger or by wiring application-level update logic in places that call the users table). Update any related types/migrations that rely on the users schema (references to users, id, email, name) so the new fields are included and non-nullable defaults are handled.betterbase/templates/base/package.json (1)
17-17: Pin@types/bunto a version range instead of"latest".Using
"latest"means every install can pull a different version, risking non-reproducible builds and surprise type breakage. Pin it to a caret range (e.g.,"^1.1.0") consistent with the Bun version you target.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@betterbase/templates/base/package.json` at line 17, The dependency entry "@types/bun": "latest" in package.json should be changed to a pinned caret range to ensure reproducible installs; replace "latest" with an explicit semver range such as "^1.1.0" (or the caret range matching the Bun version you target) so that the package entry for "@types/bun" uses a fixed compatible range rather than "latest". Ensure the new string is a valid semver range and update any accompanying lockfile if present.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@betterbase/apps/dashboard/README.md`:
- Around line 1-3: Update the README under the "Dashboard App (Scaffold)"
heading to include an optional scaffolded structure for future development: add
a short "Planned Features" list, a "Tech Stack" section naming
frameworks/libraries, a "Setup" placeholder with basic steps or commands, and a
"Related Docs / Links" section for design docs or tickets; keep these as
optional bullet placeholders so maintainers can easily expand them later.
In `@betterbase/templates/base/package.json`:
- Line 17: The dependency entry "@types/bun": "latest" in package.json should be
changed to a pinned caret range to ensure reproducible installs; replace
"latest" with an explicit semver range such as "^1.1.0" (or the caret range
matching the Bun version you target) so that the package entry for "@types/bun"
uses a fixed compatible range rather than "latest". Ensure the new string is a
valid semver range and update any accompanying lockfile if present.
In `@betterbase/templates/base/src/db/index.ts`:
- Around line 1-6: The current call drizzle(sqlite) omits the schema so Drizzle
cannot provide relational query builders or full type inference; update the
module to import your generated/defined schema (e.g., import { schema } from
'./schema' or the file where your tables/types are defined) and pass it into
drizzle as drizzle(sqlite, { schema }) so exports like db (and usages such as
db.query.users) gain relational helpers and proper typings; keep the existing
sqlite Database instantiation and export name db.
In `@betterbase/templates/base/src/db/schema.ts`:
- Around line 3-7: Add audit timestamps to the users table by extending the
existing sqliteTable('users', ...) schema: add createdAt and updatedAt columns
(e.g., timestamp/datetime or integer epoch) with createdAt defaulting to the
current timestamp and updatedAt defaulting to the current timestamp as well;
ensure updatedAt is set/updated on record updates (either via a DB trigger or by
wiring application-level update logic in places that call the users table).
Update any related types/migrations that rely on the users schema (references to
users, id, email, name) so the new fields are included and non-nullable defaults
are handled.
In `@betterbase/templates/base/src/middleware/validation.ts`:
- Around line 8-11: createUserSchema is defined but not used; either remove it
or wire it into the user-creation flow — if it's intended scaffolding, mark it
explicitly as a placeholder. To fix: if keeping, add a clear TODO comment above
createUserSchema stating it's a placeholder and then import and use
createUserSchema in your user route handler (e.g., call
createUserSchema.parse(req.body) or safeParse in the
createUser/createUserHandler function) so the linter sees it used; otherwise
delete the createUserSchema export to avoid dead code.
- Around line 4-6: parseBody currently calls schema.parse which throws a raw
ZodError; change it to validate using schema.safeParse inside parseBody (or
provide a Hono middleware wrapper) and when validation fails return/throw a
Hono-friendly 400 response payload containing the validation errors instead of
propagating the raw ZodError. Update the parseBody<T>(schema: ZodType<T>, body:
unknown) implementation to call schema.safeParse(body), check result.success,
and map result.error.issues into a structured error object (or throw a custom
HttpError/Response) so callers receive a formatted 400 rather than an unhandled
500.
In `@betterbase/templates/base/tsconfig.json`:
- Around line 1-21: Update this tsconfig.json to extend
"../../tsconfig.base.json" so it inherits shared options (like isolatedModules,
forceConsistentCasingInFileNames and the `@/`* path alias) instead of duplicating
them; remove the redundant "noImplicitAny" entry under "compilerOptions" (since
"strict": true already covers it) and keep the template-specific overrides
(e.g., "target", "module", "moduleResolution", "types", "outDir" and the
"include" array) so local settings remain intact while shared settings come from
the base.
In `@betterbase/tsconfig.base.json`:
- Around line 6-7: The tsconfig currently sets both "strict": true and
"noImplicitAny": true which is redundant; remove the explicit "noImplicitAny"
entry from the base tsconfig (and the template tsconfig) so that "strict": true
governs the setting; update any comments if present to note that strict enables
noImplicitAny and run a quick TypeScript build to confirm no behavior change.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@betterbase/templates/base/src/routes/users.ts`:
- Around line 6-17: The POST handler in usersRoute currently calls c.req.json()
which will throw on malformed JSON and produce a 500; update the usersRoute.post
handler to try/catch the await c.req.json() call, and on SyntaxError throw or
return an HTTP 400 using Hono's HTTPException (import { HTTPException } from
'hono/http-exception') with a clear message like "Malformed JSON" before calling
parseBody(createUserSchema, body); keep parseBody(createUserSchema, body) and
the successful c.json(...) response unchanged.
In `@betterbase/tsconfig.base.json`:
- Around line 12-16: The base tsconfig's "paths" mapping for the "@/*" alias
currently points to "./src/*" which resolves to a non-existent betterbase/src/*
for all child projects; remove the "paths" entry from the base tsconfig (the
"paths" object containing "@/*") or add/override "paths" in each child tsconfig
(e.g., apps/cli and templates/base) to map "@/*" to their local "./src/*" so
imports using "@/..." resolve to the child's source directory.
Comment on lines
+6
to
+17
| usersRoute.post('/', async (c) => { | ||
| const body = await c.req.json(); | ||
| const parsed = parseBody(createUserSchema, body); | ||
|
|
||
| return c.json( | ||
| { | ||
| message: 'User payload validated', | ||
| user: parsed, | ||
| }, | ||
| 201, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
c.req.json() will throw an unhandled error on malformed JSON.
If the request body is not valid JSON, c.req.json() throws a SyntaxError which bypasses your parseBody validation and results in a generic 500 instead of a 400. Wrap it or handle the error:
Proposed fix
usersRoute.post('/', async (c) => {
- const body = await c.req.json();
- const parsed = parseBody(createUserSchema, body);
+ let body: unknown;
+ try {
+ body = await c.req.json();
+ } catch {
+ throw new HTTPException(400, { message: 'Invalid JSON body' });
+ }
+ const parsed = parseBody(createUserSchema, body);This requires adding the import:
import { HTTPException } from 'hono/http-exception';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@betterbase/templates/base/src/routes/users.ts` around lines 6 - 17, The POST
handler in usersRoute currently calls c.req.json() which will throw on malformed
JSON and produce a 500; update the usersRoute.post handler to try/catch the
await c.req.json() call, and on SyntaxError throw or return an HTTP 400 using
Hono's HTTPException (import { HTTPException } from 'hono/http-exception') with
a clear message like "Malformed JSON" before calling parseBody(createUserSchema,
body); keep parseBody(createUserSchema, body) and the successful c.json(...)
response unchanged.
This was referenced Feb 17, 2026
weroperking
pushed a commit
that referenced
this pull request
Feb 19, 2026
…ndings-and-nitpicks-5zz0g3 Codex-generated pull request
Merged
weroperking
pushed a commit
that referenced
this pull request
Feb 20, 2026
…ckage feat(client): scaffold @betterbase/client TypeScript SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task
Summary by CodeRabbit
New Features
Documentation
Chores