Make explicit DXVK mode strict: no fallback to WineD3D#33
Merged
Conversation
- Implemented strict DLL overrides (`=n`) in `build_dll_overrides` to prevent Wine from falling back to built-in WineD3D when DXVK is explicitly requested. - Enhanced pre-launch validation in `ResolveDllProvidersStage` to include `d3d10core` and fail if any required DXVK DLLs are missing for the target architecture. - Updated the launch pipeline to treat backend policy violations as a `Failure` state when DXVK is requested. - Added a `STRICT_DXVK_POLICY_VIOLATION` diagnostic warning to `LaunchInvariantValidator` when WineD3D usage is observed despite a DXVK request. - Updated sanity checks and unit tests to reflect and verify the strict enforcement policy. - Maintained existing permissive behavior for `Auto` mode. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Enriched `WINEDLLPATH` in `WineTkgRunner` to explicitly include arch-specific subdirectories (`x86_64-windows`, `i386-windows`) for all runner library paths. - Added runner DLL directories to `WINEPATH` to aid Wine's native PE loader in resolving dependencies (fixing error c0000135). - Enhanced evidence classification in `wine_capture.rs` to detect "Failed to load module" and "Library ... not found" messages from Wine logs. - Improved failure diagnostics in `LaunchInvariantValidator` to report precise details about which DLL failed to load, its provider, path, and architecture. - Added `d3d10` and `d3d10_1` to strict pre-launch validation in `ResolveDllProvidersStage` for full D3D10 stack coverage. - Fixed a compilation error in `WineTkgRunner` where an incorrect variable name was used. - Updated unit tests to align with the latest strict mode argument requirements. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
- Refactored `ResolveDllProvidersStage` to use DXVK capability dependency sets (DX11/DXGI, DX10, DX9, DX8) instead of requiring literal DLL lists. - Removed incorrect requirements for `d3d10.dll` and `d3d10_1.dll`, which are not present in standard DXVK layouts (DX10 support is provided via `d3d10core.dll`). - Improved error messages to accurately describe missing translation capabilities and their specific DLL requirements. - Ensured Batman: Arkham Origins (X86) no longer fails validation due to false-missing DLL errors. - Maintained strict explicit-DXVK policy by requiring all applicable capabilities for a complete stack. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enforces a strict backend policy when a user explicitly selects DXVK. It prevents silent fallbacks to WineD3D by using native-only overrides, performs more comprehensive pre-launch DLL validation (now including d3d10core), and ensures that any observed WineD3D usage during a DXVK-requested launch is treated as a session failure. These changes ensure that the launcher's reporting remains truthful and that users are clearly notified of environment issues that prevent DXVK from being used.
PR created automatically by Jules for task 2121893909168592742 started by @weter11