Skip to content

feature(comp): adds <Modal> component#63

Merged
marlonmarcello merged 20 commits into
mainfrom
feature/comp/modal
Dec 4, 2023
Merged

feature(comp): adds <Modal> component#63
marlonmarcello merged 20 commits into
mainfrom
feature/comp/modal

Conversation

@marlonmarcello
Copy link
Copy Markdown
Member

@marlonmarcello marlonmarcello commented Nov 23, 2023 •
edited
Loading

Description

Closes #60

Solution

Adds a simple <Modal /> component 😃

Screenshots

Screen.Recording.2023-11-24.at.1.17.43.PM.mov

@marlonmarcello marlonmarcello mentioned this pull request Nov 24, 2023
Merged
@marlonmarcello marlonmarcello changed the title feature(comp): adds <Modal> component feature(comp): adds <Modal> and useAnimatePresence Nov 24, 2023
@marlonmarcello marlonmarcello self-assigned this Nov 24, 2023
@marlonmarcello marlonmarcello added DOCS Improvements or additions to Storybook docs enhancement New feature or request CLI Tickets related to wethegit-components-cli COMP Tickets related to wethegit-components labels Nov 24, 2023
@marlonmarcello marlonmarcello added this to the v1 milestone Nov 24, 2023
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f7a7eb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@wethegit/components-cli Patch
@wethegit/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marlonmarcello marlonmarcello marked this pull request as draft November 27, 2023 19:09
@marlonmarcello
Copy link
Copy Markdown
Member Author

marlonmarcello commented Nov 27, 2023

Changing this back to a draft. Going to move useAnimatePresence to react-hooks with the Typescript and Changeset improvements

@andrewrubin
Copy link
Copy Markdown
Member

andrewrubin commented Nov 27, 2023 •
edited
Loading

Going to move useAnimatePresence to react-hooks

Nice, I was going to suggest this. Should I wait to review it there?
I'll withhold a review until we've had a chance to get everything updated in the modal and hooks repos

@marlonmarcello marlonmarcello changed the title feature(comp): adds <Modal> and useAnimatePresence feature(comp): adds <Modal> component Nov 28, 2023
@marlonmarcello marlonmarcello marked this pull request as ready for review November 28, 2023 23:05
andrewrubin
andrewrubin reviewed Nov 29, 2023
View reviewed changes
Comment thread packages/wethegit-components/src/components/modal/modal.tsx Outdated
andrewrubin
andrewrubin previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andrewrubin andrewrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @marlonmarcello , I think this is better too, thanks for making the update.

Should we add a story that uses a button to trigger it? Or does that overcomplicate things?

@marlonmarcello
Copy link
Copy Markdown
Member Author

marlonmarcello commented Dec 2, 2023

Nice one @marlonmarcello , I think this is better too, thanks for making the update.

Should we add a story that uses a button to trigger it? Or does that overcomplicate things?

Done!

andrewrubin
andrewrubin approved these changes Dec 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andrewrubin andrewrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, let's gooo!

@marlonmarcello marlonmarcello merged commit 6a272a2 into main Dec 4, 2023
@marlonmarcello marlonmarcello deleted the feature/comp/modal branch December 4, 2023 17:37
@github-actions github-actions Bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewrubin andrewrubin andrewrubin approved these changes

@liamegan liamegan Awaiting requested review from liamegan

@ste-vg ste-vg Awaiting requested review from ste-vg

@NicholasLancey NicholasLancey Awaiting requested review from NicholasLancey

@rvno rvno Awaiting requested review from rvno

@chanroyc chanroyc Awaiting requested review from chanroyc

Assignees

@marlonmarcello marlonmarcello

Labels

CLI Tickets related to wethegit-components-cli COMP Tickets related to wethegit-components DOCS Improvements or additions to Storybook docs enhancement New feature or request

Projects

None yet

Milestone

v1

Development

Successfully merging this pull request may close these issues.

[COMP] Modal

2 participants

@marlonmarcello @andrewrubin