feat(PaginationItem): Expose the gallery-pagination-item component#10
Merged
Conversation
andrewrubin
reviewed
Sep 26, 2023
marlonmarcello
requested changes
Sep 26, 2023
ac80687 to
4fa320a
Compare
andrewrubin
requested changes
Oct 17, 2023
Member
andrewrubin
left a comment
There was a problem hiding this comment.
Some tiny docs changes and I think we'll be good to go!
andrewrubin
approved these changes
Oct 23, 2023
Member
There was a problem hiding this comment.
Couple extra tweaks before we merge, lmk if anyone has any concerns:
- Refactored the existing
renderGalleryItemcallback to use a property name ofindexinstead ofi. This matches the newrenderPaginationItemconvention. - Refactored all demos and documentation (existing and new) to use
item.idas thekeyprop, as this is more in line with proper React conventions. - Bumped the package to
3.0.0
marlonmarcello
approved these changes
Oct 23, 2023
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A feature request to expose the Pagination Item render elements
<li>and<button>to allow for easier styling and control.Solution
index,active,activeIndex, anditemprops.<GalleryPaginationItem>componentbuttonClassnameandbuttonPropsto pass to<button>elementonClickand callonClickprop in thehandleClick()Note
renderPaginationItemprop was retained and conditional is set to prevent breaking changes if the package is updated.TODO
onClickcallbackExisting issue mentioned: #7