Skip to content

patch: optional params#10

Merged
marlonmarcello merged 2 commits into
mainfrom
patch/optional-params
Nov 29, 2023
Merged

patch: optional params#10
marlonmarcello merged 2 commits into
mainfrom
patch/optional-params

Conversation

@marlonmarcello
Copy link
Copy Markdown
Member

Description

All parameters of the hook are optional, right now if you don't pass art least an empty object it throws an errors trying to de-structure

Solution

Ensures we have an empty object.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: cc2a0e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wethegit/react-modal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marlonmarcello marlonmarcello added the bug Something isn't working label Nov 29, 2023
Copy link
Copy Markdown
Member

@andrewrubin andrewrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, 🚢

@marlonmarcello marlonmarcello merged commit 1e4fba5 into main Nov 29, 2023
@marlonmarcello marlonmarcello deleted the patch/optional-params branch November 29, 2023 22:16
@github-actions github-actions Bot mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants