[component] patch: fix body locking unnecessarily#12
Merged
Conversation
🦋 Changeset detectedLatest commit: cab88f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marlonmarcello
requested review from
NicholasLancey,
andrewrubin,
chanroyc,
liamegan,
rvno and
ste-vg
Member
|
This brings up another interesting question @marlonmarcello , do we also need to disable the focus trap, if appendToBody is false? Or give the option to? I think we probably don't, as it's still an "alert" that requires the users attention. Thoughts? |
andrewrubin
approved these changes
Dec 4, 2023
Member
Author
|
@andrewrubin isn't that a best practice regardless if the modal is on the body or not? Like, won't people tabbing just keep going through the site with the modal opened? |
Member
|
Yeah, I think you're right Marlon, let's keep it as is |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The modal was setting
overflow: hiddento the body even though we were not appending it to the body,Solution
Used the
appendToBodyvariable to determine if we should lock the body or not.