Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-ravens-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wethegit/react-modal": minor
---

Fix: positiong class names not being passed down if appendToBody is true
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"editor.codeActionsOnSave": {
"source.fixAll": true
"source.fixAll": "explicit"
},
"eslint.format.enable": true,
"eslint.nodePath": "",
Expand Down
4,373 changes: 2,458 additions & 1,915 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wethegit/react-modal",
"version": "2.0.2",
"version": "2.1.0",
"description": "A customizable, accessible modal window component for React projects.",
"files": [
"dist"
Expand Down
7 changes: 3 additions & 4 deletions src/lib/components/modal-inner/modal-inner.module.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
.modalInner {
align-items: center;
display: flex;
inset: 0;
position: fixed;
justify-content: center;
width: 100%;
z-index: 1;
display: flex;
align-items: center;
justify-content: center;
}
22 changes: 12 additions & 10 deletions src/lib/components/modal/modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@ export interface ModalProps extends ModalInnerProps {
export function Modal({ appendToBody, className, ...props }: ModalProps) {
usePreventScroll(appendToBody)

if (appendToBody) return ReactDOM.createPortal(<ModalInner {...props} />, document.body)
else
return (
<ModalInner
className={classnames([
appendToBody ? styles.ModalFixed : styles.ModalAbsolute,
className,
])}
{...props}
/>
const classes = classnames([
appendToBody ? styles.ModalFixed : styles.ModalAbsolute,
className,
])

if (appendToBody) {
return ReactDOM.createPortal(
<ModalInner className={classes} {...props} />,
document.body
)
} else {
return <ModalInner className={classes} {...props} />
}
}
6,113 changes: 6,113 additions & 0 deletions yarn.lock

Large diffs are not rendered by default.