refactor: simplify proc ID handling and exec return type#22
Merged
Conversation
- Change Proc.String() to Proc.ID() returning just endpoint name - Change Endpoint.String() to return full protocol string with /ww/0.1.0/ prefix - Update exec command to return process ID instead of full protocol string - Update send command to construct protocol internally from process ID - Add proper docstrings to String(), ID(), and Protocol() methods - Update tests and documentation to reflect new behavior This simplifies the API by making exec return just the process ID while maintaining proper protocol handling internally for libp2p stream routing.
mikelsr
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the process ID API by making
execreturn just the process ID while maintaining proper protocol handling internally.Changes
Proc.String()→Proc.ID(): Returns just endpoint name (e.g., "abc123")Endpoint.String(): Returns full protocol string (e.g., "/ww/0.1.0/abc123")execcommand: Returns process ID instead of full protocol stringsendcommand: Constructs protocol internally from process IDBenefits
(exec ...)returns simple ID,(send ...)takes simple IDTesting