fix: preserve validation messages in tty output#127
Closed
gluckzhang wants to merge 1 commit intowevm:mainfrom
Closed
fix: preserve validation messages in tty output#127gluckzhang wants to merge 1 commit intowevm:mainfrom
gluckzhang wants to merge 1 commit intowevm:mainfrom
Conversation
Signed-off-by: Long Zhang <gluckzhang@gmail.com>
gluckzhang
force-pushed
the
validation-error-messages
branch
from
986a858 to
45fa7cd
Compare
Member
|
Closing in favor of #138 |
Contributor
Author
|
Thanks for taking care of this @tmm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes misleading TTY validation output when a value is present but fails Zod validation. Previously, human-readable errors rewrote all field validation failures as missing arguments, so cases like
--address abcwithz.string().min(32)incorrectly rendered asmissing required argument <address>.The fix preserves structured Zod issue metadata in parser field errors and updates human formatting to distinguish true missing input from invalid values. Missing args still render as missing, while provided-but-invalid options and positionals now show the real validation message, such as
invalid value for --address: Too small: expected string to have >=32 characters. Machine/JSON output remains compatible and continues to expose the underlying validation details.