Skip to content

WV-2261 - Fixed search for preferred name. Added cross icon to clear search box. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Almee98 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

WV-2261 - Fixed search for preferred name. Added cross icon to clear search box. #135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b53770
WV-2261 - Fixed search for preferred name. Added cross icon to clear …
Dec 23, 2025
6b101ac
fixed package-lock.json
Dec 23, 2025
d8bd932
Removed a modified file from pull request
Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/js/components/Person/AddPersonDrawerMainContent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
import { SpanWithLinkStyle } from '../Style/linkStyles';
import { MatchingPerson, SearchBarWrapper } from '../Style/sharedStyles';
import AddPersonForm from './AddPersonForm';
import CrossIcon from '../../../img/global/svg-icons/cross.svg';

const LIMIT_NUMBER_SHOWN = 20;

Expand All @@ -38,7 +39,7 @@ const AddPersonDrawerMainContent = () => {
const [teamMemberPersonIdList] = useState([]);
const [matchingCountText, setMatchingCountText] = useState('');

const searchStringInputRef = useRef('');
const searchStringInputRef = useRef(null);

const updateRemainingPeopleToAdd = () => {
// console.log('initializeTheRemainingPeopleToAddListList in AddPersonDrawerMainContent');
Expand Down Expand Up @@ -103,7 +104,7 @@ const AddPersonDrawerMainContent = () => {
setSearchResultsList(undefined);
} else {
const isMatch = (element) => (element.lastName.toLowerCase().includes(currentValue.toLowerCase()) ||
element.firstName.toLowerCase().includes(currentValue.toLowerCase()));
element.firstName.toLowerCase().includes(currentValue.toLowerCase()) || element.firstNamePreferred?.toLowerCase().includes(currentValue.toLowerCase()));
const matchingElements = remainingPeopleToAdd ? remainingPeopleToAdd.filter((element) => isMatch(element)) : {};
if (matchingElements && matchingElements.length) {
setSearchResultsList(matchingElements);
Expand All @@ -115,6 +116,12 @@ const AddPersonDrawerMainContent = () => {
}
};

const clearSearch = () => {
searchStringInputRef.current.value = '';
setSearchResultsList(undefined);
setMatchingCountText('');
};

const addClicked = (incomingPerson) => {
const personId = incomingPerson ? incomingPerson.personId : -1;
const teamId = team ? team.teamId : -1;
Expand Down Expand Up @@ -153,6 +160,16 @@ const AddPersonDrawerMainContent = () => {
placeholder="Search by name"
defaultValue=""
sx={{ minWidth: '250px' }}
InputProps={{
endAdornment: searchStringInputRef.current?.value ? (
<span
onClick={clearSearch}
style={{ cursor: 'pointer', display: 'flex', alignItems: 'center' }}
>
<img src={CrossIcon} alt="Clear search" style={{ width: 14, height: 14 }} />
</span>
) : null,
}}
/>
<MatchingPerson>{matchingCountText}</MatchingPerson>
</SearchBarWrapper>
Expand Down
Loading