Closed
Conversation
JohnKallies
reviewed
Nov 2, 2022
Contributor
JohnKallies
left a comment
JohnKallies
left a comment
There was a problem hiding this comment.
This is a good start. It needs a route and a server call still
JohnKallies
reviewed
Nov 9, 2022
JohnKallies
reviewed
Nov 9, 2022
JohnKallies
reviewed
Nov 9, 2022
JohnKallies
reviewed
Nov 9, 2022
removed all params as per new updated api route spec added route in the rich-skill-service file route will be /api/export/library. Created the component that will call the route and return it and download it to users folder. Button is now hidden when not authorized and visible when user with proper role has access to it. Added the path to routerLink so it just stays in the same page when clicked on created button for library export button checks auth roles to make sure only users with access can export
wgu-edwin
force-pushed
the
feature/download-library-button
branch
from
3009be6 to
b8d2567
Compare
JohnKallies
reviewed
Nov 10, 2022
hikr17
reviewed
Nov 11, 2022
JohnKallies
reviewed
Nov 14, 2022
it tests the onDownloadLibrary function and makes sure it's called correctly
hikr17
reviewed
Nov 15, 2022
JohnKallies
reviewed
Nov 16, 2022
JohnKallies
reviewed
Nov 16, 2022
removed unnecessary whitespace and removed unused variables. fixed the async issue that could have been a problem later on
JohnKallies
approved these changes
Nov 18, 2022
Contributor
JohnKallies
left a comment
JohnKallies
left a comment
There was a problem hiding this comment.
Thanks for tracking the details. To me, this matters.
Contributor
|
I see this UI work as complete, nicely done. We will merge this after the API code for export. |
Contributor
|
Completed in #265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
button checks auth roles to make sure only users with access can export