Skip to content

fix for removing RSD from collection#321

Closed
schagantiwgu wants to merge 1 commit intodevelopfrom
bugfix/osmt-86
Closed

fix for removing RSD from collection#321
schagantiwgu wants to merge 1 commit intodevelopfrom
bugfix/osmt-86

Conversation

@schagantiwgu
Copy link
Contributor

No description provided.

@schagantiwgu schagantiwgu marked this pull request as draft March 1, 2023 17:54
@JohnKallies JohnKallies marked this pull request as ready for review March 3, 2023 16:57
@JohnKallies JohnKallies requested a review from a team March 3, 2023 16:57
@JohnKallies JohnKallies added bug Something isn't working javascript Pull requests that update Javascript code labels Mar 3, 2023
Copy link
Contributor

@manuel-delvillar manuel-delvillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when I remove 1 RSD from the collection, but seems when I type a query in input "Search RSD in this collection" is not working.

@manuel-delvillar
Copy link
Contributor

On Friday, we also added changes to manage collection in loadNextPage().
It seems that on that branch with those changes, OSMT-86 in Jira is fixed (although we are under review and if we make changes that fix might disappear on our branch)

@JohnKallies What happens in these cases?

I ask this because depending on the final solution on each branch, we could have a conflict when merge on develop.

@JohnKallies
Copy link
Contributor

These changes were fixed in #312. Closing...

@JohnKallies JohnKallies closed this Mar 8, 2023
@JohnKallies JohnKallies deleted the bugfix/osmt-86 branch March 8, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants

Comments