Escape pattern chars in pattern base URLs. (Fixes #170)#172
Merged
Conversation
Member
Author
|
@domenic PTAL. Thanks. Corresponding chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 11, 2022
This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf
domenic
reviewed
Nov 14, 2022
wanderview
force-pushed
the
dev-escape-base-url
branch
from
2641db6 to
448dd0f
Compare
wanderview
force-pushed
the
dev-escape-base-url
branch
from
448dd0f to
ebeb70d
Compare
Member
Author
|
@domenic PTAL. Thanks. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 15, 2022
This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 16, 2022
This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919}
domenic
approved these changes
Nov 16, 2022
Co-authored-by: Domenic Denicola <d@domenic.me>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 17, 2022
This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 21, 2022
…s., a=testonly Automatic update from web-platform-tests URLPattern: Escape pattern baseURL values. This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919} -- wpt-commits: 77d95d52351ebf51bc80ee21eea455de31a5e356 wpt-pr: 36923
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 21, 2022
…s., a=testonly Automatic update from web-platform-tests URLPattern: Escape pattern baseURL values. This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919} -- wpt-commits: 77d95d52351ebf51bc80ee21eea455de31a5e356 wpt-pr: 36923
crowlKats
added a commit
to crowlKats/rust-urlpattern
that referenced
this pull request
Jul 26, 2024
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…s., a=testonly Automatic update from web-platform-tests URLPattern: Escape pattern baseURL values. This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071919} -- wpt-commits: 77d95d52351ebf51bc80ee21eea455de31a5e356 wpt-pr: 36923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff