Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the functionality to perform name mangling from an AST.
Introduced three types of nodes to assist this purpose better:
Node('abominable'): Handle function type withcvandrefqualifiers, distinguishing that from acv/ref-qualified type. The associated change also fixes a bug when formatting methods.CastNode('entity'): Still calling it a cast since it spellsL...E. Passing a function as a non-type&can be supported by this without introducing the full-expression.Node('oper_unary'): Need that to mangle unary+,-,&,*differently.Unsupported features:
_Cursor, or analysis identity of Python objects)Unverified:
Future improvements:
__1but still get name mangling that suitslibc++using some knob.The change also moved the project to use
pyproject.toml, lockedpytestin a test group usinguv, and migrated the tests topytest.