Add some new helper methods to upstream#99
Open
meramsey wants to merge 4 commits intowhitesource-ps:masterfrom
Open
Add some new helper methods to upstream#99meramsey wants to merge 4 commits intowhitesource-ps:masterfrom
meramsey wants to merge 4 commits intowhitesource-ps:masterfrom
Conversation
Signed-off-by: Michael Ramsey <mike@hackerdise.me>
Contributor
Author
|
@NatalyaDalid any chance this can be this merged? I tried to fix the signoff DCO stuff, but looks like it's still not working :( not sure if you still get notified if that fails or not Thanks in advance. |
ramibo
approved these changes
Mar 1, 2022
| sort_by=sort_by) | ||
| return products | ||
|
|
||
| def get_product_by_name(self, |
Contributor
There was a problem hiding this comment.
Check get_scopes_from_name() to be used instead.
Contributor
Author
There was a problem hiding this comment.
Yes but that returns a list. In this helper function you get only one result
Contributor
There was a problem hiding this comment.
Hi @meramsey - it returns a list for cases where you might have more than 1 entity with the same name :
- Global organization --> products with the same name in different organizations.
- Non-global organization--> projects with the same name within different products.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some stuff I had made before using sdk that I felt might be useful to have in the SDK.
Added some tests and it looks like my black formatter also kept trying to fix pep8 stuff.
Also noticed errors when trying to run the tests when adding mine due to the mock library not being in main or extras. Seemed like having requirements-dev.txt made most sense but feel free to adjust as needed.
Is there any opposition to maybe running black against the code base as a single commit so that going forward contributions using black formatting don't have to worry about whitespace and stuff?
More about Black
https://black.readthedocs.io/en/stable/