Now with support for custom loaders and relative resolve via basePath#12
Open
kristianmandrup wants to merge 6 commits intowhitlockjc:masterfrom
Open
Now with support for custom loaders and relative resolve via basePath#12kristianmandrup wants to merge 6 commits intowhitlockjc:masterfrom
kristianmandrup wants to merge 6 commits intowhitlockjc:masterfrom
Conversation
Owner
|
The changes related to lint will not be accepted. I get that there is a discrepancy with ESLint settings and your editor but I am not changing the project settings for this. In fact, VS Code has an ESLint plugin that should handle this. Let me see if I can make sense of the pertinent changes. |
e01d374 to
fdea891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to (temporarily) delete
.eslintrcsince it didn't play nice with my current editor (VSC) settings.