Update to pgp and RustCrypto (ssh-key, etc.) pre-release APIs#97
Draft
overhacked wants to merge 2 commits intowiktor-k:mainfrom
Draft
Update to pgp and RustCrypto (ssh-key, etc.) pre-release APIs#97overhacked wants to merge 2 commits intowiktor-k:mainfrom
pgp and RustCrypto (ssh-key, etc.) pre-release APIs#97overhacked wants to merge 2 commits intowiktor-k:mainfrom
Conversation
Incomplete work. `cargo test --lib --tests` works, but `cargo test --examples` won't compile, mostly because `pgp` crate dependencies don't get along with crypto pre-releases, yet. Signed-off-by: Ross Williams <ross@ross-williams.net>
The `pgp` crate hasn't yet released a version compatible with upcoming RustCrypto >0.9.x (currently in pre-release). These changes are compatible with `pgp` crate API changes as well as pending pull requests rpgp/rpgp#573 and rpgp/rpgp#705. This commit has been tested against a merge of `pgp` main (as of rpgp/rpgp@21b56ad) and the above pull requests. If the `pgp` crate API changes before its next release, this commit will need to be modified. Signed-off-by: Ross Williams <ross@ross-williams.net>
|
I'm packaging this crate for Debian and also need the |
Owner
|
After thinking about it for a while it seems the I'd be OK with dropping that example. Updates to other deps seem more straightforward so we could merge them in. What do you think about it @overhacked ? (I don't want to drop your hard work if it can still be salvaged) |
Collaborator
Author
|
I'm inclined to agree with you, for simplicity's sake. I did have quite the adventure adapting to the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: If the
pgpcrate or any RustCrypto crate APIs change before their next release, this pull request will need to be modified.NOTE: This PR will not compile without modifying
Cargo.tomlto usepathdependencies to vendor the below-noted, unreleased changes topgp. Currently the RustCrypto crates are pushing pre-releases to crates.io, sopathdependencies are not required forssh-key, etc.The
pgpcrate hasn't yet released a version compatible with upcoming RustCrypto 0.9.x (currently in pre-release). These changes are compatible withpgpcrate API changes as well as pending pull requests rpgp/rpgp#573 and rpgp/rpgp#705. This commit has been tested against a merge ofpgpmain (as of rpgp/rpgp@21b56ad) and the above pull requests.This pull request includes the dependency updates from #96.