Implement update to specific version in the ProsperoInstallationManager (wildlfy-core req) #979
Conversation
|
CI jobs are expected to fail. |
TomasHofman
force-pushed
the
update-version-manager-spi
branch
from
03919a5 to
99bb26c
Compare
TomasHofman
force-pushed
the
update-version-manager-spi
branch
3 times, most recently
from
a158f5c to
6276e1c
Compare
|
@TomasHofman we need to approve this as well? |
TomasHofman
force-pushed
the
update-version-manager-spi
branch
2 times, most recently
from
bebf757 to
622457e
Compare
|
@pedro-hos yes please, review this one as well, I was just waiting for merging of Bartek's PR to rebase this one. |
|
@yersan I'm keeping this one as draft until we have wildfly-installation-manager-api release ready, but it's ready for review as well. |
|
CI is going to keep failing because there is dependency on SNAPSHOT version of installation-manager-api. |
|
@yersan actually you don't have to review this one (unless you want to), it's OK if you just review the wildfly-core and installation-manager-api. My mistake... :) |
TomasHofman
force-pushed
the
update-version-manager-spi
branch
from
622457e to
e7d47fd
Compare
pedro-hos
left a comment
pedro-hos
left a comment
There was a problem hiding this comment.
LGTM, only that small change.
| } | ||
| String newVersion = manifestVersion.getVersion(); | ||
| String oldVersion = channelVersion.getPhysicalVersion(); | ||
| if (VersionMatcher.COMPARATOR.compare(newVersion, channelVersion.getPhysicalVersion()) < 0) { |
There was a problem hiding this comment.
can we use the oldVersion instead of the channelVersion.getPhysicalVersion() into this if condition?
2 participants
This is preparation for the implementation in wildfly-core (JBoss CLI).
Only the last commit is relevant, the other commits are from the as yet unmerged feature PR.