Skip to content

Conversation

@emmartins
Copy link
Contributor

…test

@emmartins emmartins added the hold do not merge label Sep 9, 2025
@emmartins emmartins force-pushed the fix_empty_kubernetes branch 2 times, most recently from d8f19d6 to 14ffa5a Compare September 9, 2025 18:23
@emmartins emmartins requested a review from kabir September 9, 2025 18:23
@emmartins
Copy link
Contributor Author

@kabir many times the matrix of changed quickstarts gets empty, and the final step then fail, as seen in https://github.com/wildfly/quickstart/actions/runs/17589546600
To prevent this I added an if to only set the last step needed var if it's not empty (-n)
The CI won't validate this now but I have tested this with the reverse (-z) and seems to skip correctly.

@emmartins emmartins removed the hold do not merge label Sep 9, 2025
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
echo "Calculated Matrix JSON: ${matrix}"
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but perhaps a message for the else case saying "Nothing to do" or something could be useful?

@emmartins emmartins requested a review from kabir September 10, 2025 10:40
@emmartins emmartins merged commit 098380f into wildfly:main Sep 10, 2025
47 checks passed
@emmartins
Copy link
Contributor Author

ty @kabir

@emmartins emmartins deleted the fix_empty_kubernetes branch September 10, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants