Skip to content

Conversation

@jmesnil
Copy link
Member

@jmesnil jmesnil commented Sep 11, 2025

Instead, the DB is deployed directly by the Helm Chart

Update the wildfly Helm chart to actually pulls the DB credentials from the config map (as stated in the doc) instead of hard-coding them in the values.yaml file.

This fixes https://issues.redhat.com/browse/WFLY-20915

@jmesnil jmesnil requested a review from emmartins as a code owner September 11, 2025 09:06
@emmartins
Copy link
Contributor

@jmesnil I am going to delegate the review to the owner and tester, but before I do that please update the README-source.adoc instead of the README.adoc, the latter is just a flattened version of the former, built automatically by a workflow

@jmesnil
Copy link
Member Author

jmesnil commented Sep 12, 2025

The README-source.adoc does not require any changes, they were done in the ancillary .adoc files.
Should I remove the changes in README.adoc or is there a step to generate it before I commit it?

@emmartins
Copy link
Contributor

The README-source.adoc does not require any changes, they were done in the ancillary .adoc files. Should I remove the changes in README.adoc or is there a step to generate it before I commit it?

I see, that's ok then, you can keep it, it will - at most - be rebuilt and updated after

Instead, the DB is deployed directly by the Helm Chart

Update the `wildfly` Helm chart to actually pulls the DB credentials
from the config map (as stated in the doc) instead of hard-coding them in the values.yaml file.

This fixes https://issues.redhat.com/browse/WFLY-20915

Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
@jmesnil jmesnil force-pushed the WFLY-20915_todo-backend_helm branch from 9e83fa3 to e255655 Compare October 3, 2025 07:23
@emmartins emmartins requested a review from kstekovi October 6, 2025 14:10
@emmartins
Copy link
Contributor

@jmesnil do we still need this unique (in the context of quickstarts) design of Charts.yaml + values.yaml , or could we also switch to the common design of all other quickstarts, with charts/helm.yaml ? This would allow us to fully reuse the shared-docs content related with Helm charts.
Also I think the docs could be much improved...
Anyway ^^ is not new and can be worked out in separated, the priority now is to definitely fix the bitnami issue, approving!

@emmartins emmartins merged commit 7179976 into wildfly:main Oct 16, 2025
11 checks passed
@jmesnil
Copy link
Member Author

jmesnil commented Oct 27, 2025

@emmartins We still need this structure as we are deploying a PostgreSQL resource in addition to the WildFly resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants