Imrpoved the regex#100
Closed
IlijazM wants to merge 1 commit intowiledal:masterfrom
IlijazM:improve-regex
Closed
Conversation
The regex should test for matches that don't neccassarly start at beginning of the line as well as don't end at the end. With this changes it is possible to e.g. assign a variable to a loaded json by using var json = '/*=include my.json*/'.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw some issues where people (including myself) suggested that you can use this awesome library for setting the value for variables like this:
var foo = '//=include test.json';However, this isn't possible with the current version. I updated the regex to allow to do that. I didn't really put much effort in it so you might want to clean up some things first.