fix: add expiration to download tokens (30-day TTL)#77
Open
bmersereau wants to merge 5 commits into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exp(Unix timestamp) field to every HMAC-signed download tokenverifyDownloadrejects tokens whoseexpis in the pastexpfield are still accepted (backward compat)Closes #68
Changes
backend/src/lib/downloadTokens.ts—signDownloadgains optionalttlSecondsparam (default 30 days);verifyDownloadchecksexpwhen presentbackend/src/lib/__tests__/downloadTokens.test.ts— 5 unit tests covering round-trip, tampering, exp field presence, rejection of expired tokens, and acceptance of valid tokensbackend/vitest.config.ts+backend/package.json— vitest addedTest plan
Closes Nit PR #77: Missing test for backward-compat with pre-expiry tokens (no exp field) #91