Updated setup.py testing requirements #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
approved these changes
Mar 22, 2021
Owner
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
this is a great change that simplifies the installation for most people, thank you!
Contributor
Author
|
Thank you @williballenthin! Happy to contribute to a great project :) |
Owner
|
v0.7.4 now available via pypi with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this incredibly helpful project! I just wanted to contribute some tinkering to the setup.py file that limits the installation requirements for non-development usage. I also noticed that
lxmlwas required to get unit tests passing, so I added it to that section as well. Let me know of any feedback!I didn't update the README section on installation, though can to reflect if someone wants to run the unit tests, the would need to install the library with
pip install python-evtx[test]to ensure pytest & lxml are included.