fix: alert time on upcoming events #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| fun setEventsToDisplay(newEvents: Array<EventAlertRecord>? = null) = synchronized(this) { | ||
| fun setEventsToDisplay( |
There was a problem hiding this comment.
Search resets display mode losing alert time text
Medium Severity
The setSearchText function calls setEventsToDisplay() without passing the mode parameter. Since setEventsToDisplay defaults to EventDisplayMode.ACTIVE and unconditionally sets displayMode = mode, searching in the Upcoming Events tab resets displayMode from UPCOMING to ACTIVE. This causes the "Alert at X" text to disappear for all filtered results, breaking the core feature this PR is meant to implement.
Additional Locations (1)
Code Coverage Report
|
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds a rendering mode for upcoming events and displays the next alert time in the list.
EventDisplayMode(ACTIVE,UPCOMING,DISMISSED) to control how lists render (EventDisplayMode.kt)EventListAdapterto accept amodeand, inUPCOMING, show"Alert at %s"usingevent.alertTime; keeps existing "Snoozed until" for active snoozed eventsUpcomingEventsFragmentnow callsadapter.setEventsToDisplay(..., EventDisplayMode.UPCOMING)strings.xmlentryalert_atWritten by Cursor Bugbot for commit 9e73a2d. This will update automatically on new commits. Configure here.