Signature key rotation?

[maurociancio]

Hi there,
I'd like to know if there is a way to rotate a signature key. I'd like my image proxy to work with two keys, so while I'm upgrading it on my services, it keeps responding to requests.
Any idea?
Any other solution?
I have a nginx running in front of it, so I can accept other alternatives.
Thanks!

[willnorris]

There is not currently any support for key rotation, though it would be pretty simple to add by making Proxy.SignatureKey a slice of []byte that are tried in order. I'll leave this open as a feature request to add that.

On the CLI side, I think I'd just make the signatureKey flag repeatable.

[maurociancio]

Hey, thanks!
I'll try to add it and submit it as PR. Sounds good? Will you merge it if it looks OK?

[willnorris]

Yeah, certainly... You can just make those changes in this pr

…

On Sat, Dec 28, 2019, 10:54 AM Mauro Ciancio ***@***.***> wrote: Hey, thanks! I'll try to add it and submit it as PR. Sounds good? Will you merge it if it looks OK? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#206?email_source=notifications&email_token=AAAAIWEXVZUHEC5VVKDIGIDQ26OHDA5CNFSM4J727M2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYQA5A#issuecomment-569442420>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAIWE3HIFPK3ZV4OA2CQLQ26OHDANCNFSM4J727M2A> .

[willnorris]

err, in a new PR rather. I was replying from email, and didn't see this was just an issue :)

[maurociancio]

Great!

[maurociancio]

Hi @willnorris, any chance you could merge this?