Add support for authorization token, now it's possible to get token f…#321
Closed
gerasghulyan wants to merge 2 commits into
Closed
Add support for authorization token, now it's possible to get token f…#321gerasghulyan wants to merge 2 commits into
gerasghulyan wants to merge 2 commits into
Conversation
…rom request and put in the request header to get an image of authorization required
armangevorgyan
approved these changes
Nov 4, 2021
Owner
|
Does this really need to be per-request for your use case? What if it were configured as a command line flag to imageproxy? Something like: imageproxy -passRequestHeader X-AUTH-TOKENwhich would then pass along the X-AUTH-TOKEN header for all requests that have a value for that. That would then be a bit more of a general solution that could be used for things other than auth. |
Author
|
Yes, you are right it will also work for me.
I updated my Pull Request, please look at it again.
Thanks
…On Fri, 5 Nov 2021 at 03:55, Will Norris ***@***.***> wrote:
Does this really need to be per-request for your use case? What if it were
configured as a command line flag to imageproxy? Something like:
imageproxy -passRequestHeader X-AUTH-TOKEN
which would then pass along the X-AUTH-TOKEN header for all requests that
have a value for that. That would then be a bit more of a general solution
that could be used for things other than auth.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB55B4I2B7FAZLXN7TSXZUDUKMTRTANCNFSM5HL5GYQQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
…e - imageproxy -passRequestHeader X-AUTH-TOKEN
Owner
|
I made a few small changes like supporting multiple headers, and merged this as d94e561. Thanks for the contribution! |
Author
|
Cool, thank you. |
vetler
pushed a commit
to vetler/imageproxy
that referenced
this pull request
Apr 11, 2025
Add a new passRequestHeaders field to Proxy that identifies headers to pass from inbound request to remote servers. Also add associated flag to imageproxy CLI. This is initially added to support remote servers that require an authorization token. Fixes willnorris#321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rom request and put in the request header to get an image of authorization required