Add trim option to image processing and implement trimEdges function#441
Add trim option to image processing and implement trimEdges function#441vetler wants to merge 10 commits into
Conversation
vetler
changed the title
willnorris
left a comment
willnorris
left a comment
There was a problem hiding this comment.
This is really nicely done, thanks! I've added some comments below, some just optimizations for future. I'll take a look at trying to address this also, but wanted to go ahead and jot my notes down in case you get to it first.
|
I moved the trimming up to be the first transformation, as this makes more sense. If images are trimmed after scaling for instance, then the image will not be at expected size if it is trimmed. |
|
@willnorris Are you waiting on anything more from me regarding this? Let me know if you think there's anything missing or any more tests that should be added |
Not waiting on anything from you... just hadn't made the time to get back to look at this. Will try to do so later today. |
|
I combined the tests to into a single table-driven test function, and did some other very minimal cleanup. Merged as c361000. Thanks for this! |
2 participants
Adds option "trim" to automatically trim edges of the same color.
Before, w/o trim option:
After, with /trim/ option in URL:
