Skip to content

use Set.has instead of Array.indexOf #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d1manson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use Set.has instead of Array.indexOf #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
var fs = require('fs');
var tldjs = require('tldjs');

var disposable = fs.readFileSync(__dirname + '/data/disposable.txt').toString().split('\n');
var free = fs.readFileSync(__dirname + '/data/free.txt').toString().split('\n').concat(disposable);
var disposable = new Set(fs.readFileSync(__dirname + '/data/disposable.txt').toString().split('\n'));
var free = new Set(fs.readFileSync(__dirname + '/data/free.txt').toString().split('\n').concat(disposable));

function isFree(email) {
if (typeof email !== 'string') throw new TypeError('email must be a string');
var domain = tldjs.getDomain(email.split('@').pop());
return free.indexOf(domain) !== -1;
return free.has(domain);
}

function isDisposable(email) {
if (typeof email !== 'string') throw new TypeError('email must be a string');
var domain = tldjs.getDomain(email.split('@').pop());
return disposable.indexOf(domain) !== -1;
return disposable.has(domain);
}

module.exports = {
Expand Down