Skip to content

Conversation

@rmvangun
Copy link
Contributor

This is a very large PR that refactors all packages to follow the STYLE.md guidelines. This refactor involved:

  • Standardizing comments and headers
  • Scoping shims to the object vs. the package
  • Consolidating test setup in each package to follow a more unified approach
  • Some modernization to suit recent Go versions
  • Using real config handler and dependency injector in tests so they don't have to be constantly mocked

A couple of small functional refactors were additionally required, including:

  • Adding omni to .gitignore
  • Including registry URL in the config merge/copy functionality
  • Removal of InitializeComponents in main.go
  • Reducing minimum versions allowed by tools

@rmvangun rmvangun added the chore label Apr 24, 2025
@rmvangun
Copy link
Contributor Author

Task linked: ENG-330 Test Refactoring / Cleanup

@rmvangun rmvangun self-assigned this Apr 24, 2025
@rmvangun rmvangun merged commit e85acf2 into main Apr 24, 2025
13 checks passed
@rmvangun rmvangun deleted the ENG-330_Test-Refactoring-Cleanup branch April 24, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants