Skip to content

Remove talosctl requirement #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmvangun merged 1 commit into from
May 7, 2025
Merged

Remove talosctl requirement #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions pkg/tools/tools_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,6 @@ func (t *BaseToolsManager) Check() error {
}
}

if t.configHandler.GetString("cluster.driver") == "talos" {
if err := t.checkTalosctl(); err != nil {
spin.Stop()
fmt.Fprintf(os.Stderr, "\033[31m✗ %s - Failed\033[0m\n", message)
return fmt.Errorf("talosctl check failed: %v", err)
}
}

if t.configHandler.GetString("vm.driver") == "colima" {
if err := t.checkColima(); err != nil {
spin.Stop()
Expand Down Expand Up @@ -260,25 +252,6 @@ func (t *BaseToolsManager) checkKubectl() error {
return nil
}

// checkTalosctl ensures Talosctl is available in the system's PATH using execLookPath.
// It checks for 'talosctl' in the system's PATH and verifies its version.
// Returns nil if found and meets the minimum version requirement, else an error indicating it is not available or outdated.
func (t *BaseToolsManager) checkTalosctl() error {
if _, err := execLookPath("talosctl"); err != nil {
return fmt.Errorf("talosctl is not available in the PATH")
}
output, _ := t.shell.ExecSilent("talosctl", "version", "--client", "--short")
talosctlVersion := extractVersion(output)
if talosctlVersion == "" {
return fmt.Errorf("failed to extract talosctl version")
}
if compareVersion(talosctlVersion, constants.MINIMUM_VERSION_TALOSCTL) < 0 {
return fmt.Errorf("talosctl version %s is below the minimum required version %s", talosctlVersion, constants.MINIMUM_VERSION_TALOSCTL)
}

return nil
}

// checkTerraform ensures Terraform is available in the system's PATH using execLookPath.
// It checks for 'terraform' in the system's PATH and verifies its version.
// Returns nil if found and meets the minimum version requirement, else an error indicating it is not available or outdated.
Expand Down
74 changes: 0 additions & 74 deletions pkg/tools/tools_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,24 +398,6 @@ func TestToolsManager_Check(t *testing.T) {
}
})

t.Run("TalosctlEnabledButNotAvailable", func(t *testing.T) {
// When talosctl is enabled but not available in PATH
mocks, toolsManager := setup(t, defaultConfig)
mocks.ConfigHandler.SetContextValue("cluster.driver", "talos")
originalExecLookPath := execLookPath
execLookPath = func(name string) (string, error) {
if name == "talosctl" {
return "", exec.ErrNotFound
}
return originalExecLookPath(name)
}
err := toolsManager.Check()
// Then an error indicating talosctl check failed should be returned
if err == nil || !strings.Contains(err.Error(), "talosctl check failed") {
t.Errorf("Expected Check to fail when talosctl is enabled but not available, but got: %v", err)
}
})

t.Run("ColimaEnabledButNotAvailable", func(t *testing.T) {
// When colima is enabled but not available in PATH
mocks, toolsManager := setup(t, defaultConfig)
Expand Down Expand Up @@ -809,62 +791,6 @@ func TestToolsManager_checkKubectl(t *testing.T) {
})
}

// Tests for Talosctl version validation
func TestToolsManager_checkTalosctl(t *testing.T) {
setup := func(t *testing.T) (*Mocks, *BaseToolsManager) {
t.Helper()
mocks := setupMocks(t)
toolsManager := NewToolsManager(mocks.Injector)
toolsManager.Initialize()
return mocks, toolsManager
}

t.Run("Success", func(t *testing.T) {
// Given talosctl is available with correct version
_, toolsManager := setup(t)
// When checking talosctl version
err := toolsManager.checkTalosctl()
// Then no error should be returned
if err != nil {
t.Errorf("Expected checkTalosctl to succeed, but got error: %v", err)
}
})

t.Run("TalosctlVersionInvalidResponse", func(t *testing.T) {
// Given talosctl version response is invalid
mocks, toolsManager := setup(t)
mocks.Shell.ExecSilentFunc = func(name string, args ...string) (string, error) {
if name == "talosctl" && len(args) == 3 && args[0] == "version" && args[1] == "--client" && args[2] == "--short" {
return "Invalid version response", nil
}
return "", fmt.Errorf("command not found")
}
// When checking talosctl version
err := toolsManager.checkTalosctl()
// Then an error indicating version extraction failed should be returned
if err == nil || !strings.Contains(err.Error(), "failed to extract talosctl version") {
t.Errorf("Expected failed to extract talosctl version error, got %v", err)
}
})

t.Run("TalosctlVersionTooLow", func(t *testing.T) {
// Given talosctl version is below minimum required version
mocks, toolsManager := setup(t)
mocks.Shell.ExecSilentFunc = func(name string, args ...string) (string, error) {
if name == "talosctl" && len(args) == 3 && args[0] == "version" && args[1] == "--client" && args[2] == "--short" {
return "v0.1.0", nil
}
return "", fmt.Errorf("command not found")
}
// When checking talosctl version
err := toolsManager.checkTalosctl()
// Then an error indicating version is too low should be returned
if err == nil || !strings.Contains(err.Error(), "talosctl version 0.1.0 is below the minimum required version") {
t.Errorf("Expected talosctl version too low error, got %v", err)
}
})
}

// Tests for Terraform version validation
func TestToolsManager_checkTerraform(t *testing.T) {
setup := func(t *testing.T) (*Mocks, *BaseToolsManager) {
Expand Down
Loading