Improve robustness of ExecProgress #1178
Merged
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmvangun
commented
May 16, 2025
rmvangun
commented
- Refactor ExecProgress to use sync.WaitGroup for stdout/stderr goroutines
- Call CmdWait after both goroutines finish to avoid race conditions
- Treat io.EOF and closed pipe errors as non-errors in output readers
- Always print full stdout/stderr and error details on failure
- Add diagnostic logging for command, args, and error
- No change to user-facing behavior or output
- Should eliminate "file already closed" CI flake and improve debuggability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.