fix(blueprint): Handle kustomization update scenarios correctly #1264
+303
−402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapper This commit refactors applyKustomization to use the kubeClientResourceOperation wrapper exclusively, removing all direct dynamic client usage. This change ensures that all Kubernetes operations are mockable in tests, improving testability and maintainability. The wrapper handles resource versioning and error handling consistently, reducing duplication and potential bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with kustomization updates by switching to the dynamic client and properly handling suspend states. The previous implementation could fail during updates due to improper resource version handling and would reset suspend states.
Key changes:
This change ensures that kustomization updates are handled correctly, preventing version conflicts and maintaining proper suspend states during reconciliation.