Skip to content

fix(secrets): prevent secret leakage in verbose shell output #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmvangun merged 1 commit into from
Jun 21, 2025
Merged

fix(secrets): prevent secret leakage in verbose shell output #1324

rmvangun merged 1 commit into from
Jun 21, 2025
+632 −196

Conversation

@rmvangun
Copy link
Contributor

@rmvangun rmvangun commented Jun 21, 2025

Summary

Prevents secrets from leaking into terminal output when using --verbose flag

Changes

  • Added RegisterSecret() method to shell interface
  • Secrets providers register actual secret values with shell when resolved
  • All shell command output scrubs registered secrets, replacing them with ********

@rmvangun rmvangun self-assigned this Jun 21, 2025
@rmvangun rmvangun added the bug Something isn't working label Jun 21, 2025
@rmvangun rmvangun merged commit be6c623 into main Jun 21, 2025
12 of 13 checks passed
@rmvangun rmvangun deleted the fix/scrub-verbose-secrets branch June 21, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rmvangun rmvangun

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmvangun