fix(config): Ensure proper config loading order #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A default configuration was loaded on top of the local `windsor.yaml` config. This caused incorrect template values on running `windsor init`. A few areas contributed to this. To remediate, the `--reset` logic that prevented file config loading has been removed as it is no longer the desired functionality. Furthermore, we ensure that we only load a default configuration if an existing context config has not loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default configuration was loaded on top of the local
windsor.yamlconfig. This caused incorrect template values on runningwindsor init.A few areas contributed to this. To remediate, the
--resetlogic that prevented file config loading has been removed as it is no longer the desired functionality. Furthermore, we ensure that we only load a default configuration if an existing context config has not loaded.