chore(blueprint): Add blueprint Feature type #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up the new Feature type, which behaves as a trimmed down conditional fragment of a blueprint.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| terraformComponentsCopy := make([]ConditionalTerraformComponent, len(f.TerraformComponents)) | ||
| for i, component := range f.TerraformComponents { | ||
| valuesCopy := make(map[string]any, len(component.Values)) | ||
| maps.Copy(valuesCopy, component.Values) |
There was a problem hiding this comment.
Bug: Deep Copy Methods Fail for Mutable Map Values
The DeepCopy methods for Feature and ConditionalTerraformComponent use maps.Copy() for the Values map. This performs a shallow copy, meaning if Values contains mutable types like slices or nested maps, the original and copy will share references. Modifying these shared values in one object will unexpectedly affect the other, violating deep copy behavior.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the new Feature type, which behaves as a trimmed down conditional fragment of a blueprint.