refactor(workstation): Remove dependency injector

[rmvangun]

Factors out the dependency injector from the workstation package .

Signed-off-by: Ryan VanGundy 85766511+rmvangun@users.noreply.github.com

---

Note

Replaces the DI injector with direct runtime-based wiring across workstation, network, services, and virt, simplifying initialization (e.g., AssignIPs), updating constructors, and adjusting Docker/Colima handling and tests.

• Core Refactor (DI → runtime):
  • Replace injector-based constructors with *runtime.Runtime across workstation, network, services, and virt.
  • Remove Initialize methods; use direct fields from Runtime and new flows (e.g., AssignIPs).
• Workstation:
  • NewWorkstation(rt, opts...) with optional overrides; auto-constructs deps (NetworkManager, Services, VM, ContainerRuntime, SSH).
  • Up/Down simplified (no explicit init calls); networking/DNS configured post runtime bring-up.
  • Service creation uses new service constructors and sets DNS service dependencies via SetServices.
• Network:
  • Introduce AssignIPs on BaseNetworkManager; default CIDR applied if missing.
  • ColimaNetworkManager now constructed with (rt, sshClient, secureShell, networkInterfaceProvider); ConfigureGuest uses default CIDR lookup.
• Services:
  • DNSService, RegistryService, GitLivereloadService, LocalstackService, TalosService now use NewXxxService(rt); rely on runtime.ProjectRoot and config handler directly.
  • DNSService adds SetServices and writes Corefile without shell project-root lookup.
• Virt:
  • BaseVirt takes rt; remove explicit init; consumers read shell/config from runtime.
  • ColimaVirt/DockerVirt updated accordingly; DockerVirt determines compose command robustly and uses runtime.ProjectRoot.
• Project:
  • NewProject creates workstation via workstation.NewWorkstation(rt); initialization uses AssignIPs.
• Tests:
  • Broad updates to reflect runtime-based constructors, AssignIPs, and removal of DI/Initialize; adapt mocks accordingly.

^{Written by Cursor Bugbot for commit 211bf2e. This will update automatically on new commits. Configure here.}

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 14

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Services Lack IPs: Networking Failure

The Up method never calls NetworkManager.AssignIPs(w.Services) to assign IP addresses to services. The refactor renamed Initialize to AssignIPs but removed the call from Up, leaving services without assigned IP addresses. This prevents services from getting their network configuration, breaking container networking. The AssignIPs call was removed when dependency injection was factored out but not replaced in the execution flow.

pkg/workstation/workstation.go#L123-L169

cli/pkg/workstation/workstation.go

Lines 123 to 169 in 3e1f57f

	// configures networking components, and informs the user of successful environment setup.
	func (w *Workstation) Up() error {
	if err := os.Setenv("NO_CACHE", "true"); err != nil {
	return fmt.Errorf("Error setting NO_CACHE environment variable: %w", err)
	}
	vmDriver := w.ConfigHandler.GetString("vm.driver")
	if vmDriver == "colima" {
	if w.VirtualMachine == nil {
	return fmt.Errorf("no virtual machine found")
	}
	if err := w.VirtualMachine.Up(); err != nil {
	return fmt.Errorf("error running virtual machine Up command: %w", err)
	}
	}
	for _, service := range w.Services {
	if err := service.WriteConfig(); err != nil {
	return fmt.Errorf("Error writing config for service %s: %w", service.GetName(), err)
	}
	}
	containerRuntimeEnabled := w.ConfigHandler.GetBool("docker.enabled")
	if containerRuntimeEnabled {
	if w.ContainerRuntime == nil {
	return fmt.Errorf("no container runtime found")
	}
	if err := w.ContainerRuntime.WriteConfig(); err != nil {
	return fmt.Errorf("failed to write container runtime config: %w", err)
	}
	if err := w.ContainerRuntime.Up(); err != nil {
	return fmt.Errorf("error running container runtime Up command: %w", err)
	}
	}
	if w.NetworkManager != nil {
	// Only configure guest and host routes for colima
	if vmDriver == "colima" {
	if err := w.NetworkManager.ConfigureGuest(); err != nil {
	return fmt.Errorf("error configuring guest: %w", err)
	}
	if err := w.NetworkManager.ConfigureHostRoute(); err != nil {
	return fmt.Errorf("error configuring host route: %w", err)
	}
	}
	// Configure DNS if enabled

 

---

[cursor]

Bug: Missing IP Assignment Cripples Network Startup

The Workstation.Up() method never calls NetworkManager.AssignIPs(), which is required to assign IP addresses to services before they write configs and start containers. The refactoring removed the call that used to happen via Initialize(), but didn't add it to Up(). Without IP assignment, services won't have valid addresses when WriteConfig() is called at line 144, causing networking to fail. The call should happen after VM startup but before service config writing.

pkg/workstation/workstation.go#L123-L147

cli/pkg/workstation/workstation.go

Lines 123 to 147 in 211bf2e

	// configures networking components, and informs the user of successful environment setup.
	func (w *Workstation) Up() error {
	if err := os.Setenv("NO_CACHE", "true"); err != nil {
	return fmt.Errorf("Error setting NO_CACHE environment variable: %w", err)
	}
	vmDriver := w.ConfigHandler.GetString("vm.driver")
	if vmDriver == "colima" {
	if w.VirtualMachine == nil {
	return fmt.Errorf("no virtual machine found")
	}
	if err := w.VirtualMachine.Up(); err != nil {
	return fmt.Errorf("error running virtual machine Up command: %w", err)
	}
	}
	for _, service := range w.Services {
	if err := service.WriteConfig(); err != nil {
	return fmt.Errorf("Error writing config for service %s: %w", service.GetName(), err)
	}
	}
	containerRuntimeEnabled := w.ConfigHandler.GetBool("docker.enabled")
	if containerRuntimeEnabled {
	if w.ContainerRuntime == nil {

 

---

[cursor]

Bug: Colima Networking Not Configured

For Colima environments, the workstation creates a BaseNetworkManager instead of a ColimaNetworkManager. When ConfigureGuest() is called at line 163, the base implementation is just a no-op, so the Colima-specific networking setup (SSH configuration, iptables rules, Docker bridge detection) never happens. The network manager creation should check vm.driver and instantiate ColimaNetworkManager with the required dependencies (sshClient, secureShell, networkInterfaceProvider) when using Colima.