Skip to content

chore(provisioner): Enhance test coverage #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmvangun merged 4 commits into from
Nov 15, 2025
Merged

chore(provisioner): Enhance test coverage #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e67ca5
chore(provisioner): Enhance test coverage
rmvangun Nov 15, 2025
2735511
Enhance cluster client tests
rmvangun Nov 15, 2025
14b6cbc
Enhance kubernetes manager tests
rmvangun Nov 15, 2025
aab2ebe
Enhance provisioner/terraform coverage
rmvangun Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions pkg/provisioner/cluster/cluster_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,6 @@ import (
"github.com/windsorcli/cli/pkg/constants"
)

// =============================================================================
// Test Setup
// =============================================================================

type Mocks struct {
// Add mocks as needed
}

type SetupOptions struct {
// Add setup options as needed
}

// =============================================================================
// Test Constructor
// =============================================================================
Expand Down Expand Up @@ -50,12 +38,25 @@ func TestNewBaseClusterClient(t *testing.T) {

func TestBaseClusterClient_Close(t *testing.T) {
t.Run("Success", func(t *testing.T) {
// Given a base cluster client
client := NewBaseClusterClient()

// When calling Close
// Then it should not panic
client.Close()

if client == nil {
t.Error("Expected client to remain non-nil after Close")
}
})

t.Run("CanBeCalledMultipleTimes", func(t *testing.T) {
client := NewBaseClusterClient()

client.Close()
client.Close()
client.Close()

if client == nil {
t.Error("Expected client to remain non-nil after multiple Close calls")
}
})
}

Expand Down
260 changes: 252 additions & 8 deletions pkg/provisioner/cluster/talos_cluster_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ import (
// Test Setup
// =============================================================================

// setupShims initializes and returns shims for tests
func setupShims(t *testing.T) *Shims {
t.Helper()
// setupDefaultShims initializes and returns shims with default test configurations
func setupDefaultShims() *Shims {
shims := NewShims()

shims.TalosConfigOpen = func(configPath string) (*clientconfig.Config, error) {
Expand Down Expand Up @@ -102,7 +101,7 @@ func TestTalosClusterClient_WaitForNodesHealthy(t *testing.T) {
setup := func(t *testing.T) *TalosClusterClient {
t.Helper()
client := NewTalosClusterClient()
client.shims = setupShims(t)
client.shims = setupDefaultShims()
client.healthCheckTimeout = 100 * time.Millisecond
client.healthCheckPollInterval = 10 * time.Millisecond
return client
Expand Down Expand Up @@ -277,6 +276,213 @@ func TestTalosClusterClient_WaitForNodesHealthy(t *testing.T) {
t.Errorf("Expected timeout error, got %v", err)
}
})

t.Run("ContextWithDeadline", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

ctx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
defer cancel()

client.healthCheckTimeout = 200 * time.Millisecond
client.healthCheckPollInterval = 10 * time.Millisecond

nodeAddresses := []string{"10.0.0.1"}

err := client.WaitForNodesHealthy(ctx, nodeAddresses, "")
if err != nil {
t.Errorf("Expected no error, got %v", err)
}
})

t.Run("MultipleNodesWithMixedHealth", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

callCount := 0
client.shims.TalosServiceList = func(ctx context.Context, client *talosclient.Client) (*machine.ServiceListResponse, error) {
callCount++
if callCount == 1 {
return &machine.ServiceListResponse{
Messages: []*machine.ServiceList{
{
Services: []*machine.ServiceInfo{
{
Id: "apid",
State: "Running",
Health: &machine.ServiceHealth{
Healthy: true,
},
},
},
},
},
}, nil
}
return &machine.ServiceListResponse{
Messages: []*machine.ServiceList{
{
Services: []*machine.ServiceInfo{
{
Id: "apid",
State: "Running",
Health: &machine.ServiceHealth{
Healthy: true,
},
},
},
},
},
}, nil
}

ctx := context.Background()
nodeAddresses := []string{"10.0.0.1", "10.0.0.2"}

err := client.WaitForNodesHealthy(ctx, nodeAddresses, "")
if err != nil {
t.Errorf("Expected no error, got %v", err)
}
})

t.Run("TimeoutWithUnhealthyAndVersionMismatch", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

client.healthCheckTimeout = 50 * time.Millisecond
client.healthCheckPollInterval = 10 * time.Millisecond

client.shims.TalosServiceList = func(ctx context.Context, client *talosclient.Client) (*machine.ServiceListResponse, error) {
return &machine.ServiceListResponse{
Messages: []*machine.ServiceList{
{
Services: []*machine.ServiceInfo{
{
Id: "apid",
State: "Stopped",
Health: &machine.ServiceHealth{
Healthy: false,
},
},
},
},
},
}, nil
}

client.shims.TalosVersion = func(ctx context.Context, client *talosclient.Client) (*machine.VersionResponse, error) {
return &machine.VersionResponse{
Messages: []*machine.Version{
{
Version: &machine.VersionInfo{
Tag: "v1.1.0",
},
},
},
}, nil
}

ctx := context.Background()
nodeAddresses := []string{"10.0.0.1"}
expectedVersion := "1.0.0"

err := client.WaitForNodesHealthy(ctx, nodeAddresses, expectedVersion)
if err == nil {
t.Error("Expected error, got nil")
}

if !strings.Contains(err.Error(), "unhealthy nodes") && !strings.Contains(err.Error(), "version mismatch nodes") {
t.Errorf("Expected error about unhealthy or version mismatch nodes, got %v", err)
}
})

t.Run("EmptyNodeAddresses", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

ctx := context.Background()
nodeAddresses := []string{}

err := client.WaitForNodesHealthy(ctx, nodeAddresses, "")
if err != nil {
t.Errorf("Expected no error for empty node addresses, got %v", err)
}
})

t.Run("MultipleNodesOneHealthyOneUnhealthy", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

client.healthCheckTimeout = 50 * time.Millisecond
client.healthCheckPollInterval = 10 * time.Millisecond

client.shims.TalosServiceList = func(ctx context.Context, client *talosclient.Client) (*machine.ServiceListResponse, error) {
return &machine.ServiceListResponse{
Messages: []*machine.ServiceList{
{
Services: []*machine.ServiceInfo{
{
Id: "apid",
State: "Stopped",
Health: &machine.ServiceHealth{
Healthy: false,
},
},
},
},
},
}, nil
}

ctx := context.Background()
nodeAddresses := []string{"10.0.0.1", "10.0.0.2"}

err := client.WaitForNodesHealthy(ctx, nodeAddresses, "")
if err == nil {
t.Error("Expected error when nodes are unhealthy, got nil")
}
if !strings.Contains(err.Error(), "timeout waiting for nodes") {
t.Errorf("Expected timeout error, got %v", err)
}
})

t.Run("MultipleNodesWithVersionMismatch", func(t *testing.T) {
client := setup(t)
os.Setenv("TALOSCONFIG", "/tmp/talosconfig")
defer os.Unsetenv("TALOSCONFIG")

client.healthCheckTimeout = 50 * time.Millisecond
client.healthCheckPollInterval = 10 * time.Millisecond

client.shims.TalosVersion = func(ctx context.Context, client *talosclient.Client) (*machine.VersionResponse, error) {
return &machine.VersionResponse{
Messages: []*machine.Version{
{
Version: &machine.VersionInfo{
Tag: "v1.1.0",
},
},
},
}, nil
}

ctx := context.Background()
nodeAddresses := []string{"10.0.0.1", "10.0.0.2"}
expectedVersion := "1.0.0"

err := client.WaitForNodesHealthy(ctx, nodeAddresses, expectedVersion)
if err == nil {
t.Error("Expected error when nodes have version mismatch, got nil")
}
if !strings.Contains(err.Error(), "version mismatch nodes") {
t.Errorf("Expected version mismatch error, got %v", err)
}
})
}

func TestTalosClusterClient_Close(t *testing.T) {
Expand All @@ -295,7 +501,7 @@ func TestTalosClusterClient_Close(t *testing.T) {

t.Run("SuccessWithClient", func(t *testing.T) {
client := NewTalosClusterClient()
client.shims = setupShims(t)
client.shims = setupDefaultShims()

// Set up a mock client (we'll use a non-nil pointer to simulate having a client)
mockClient := &talosclient.Client{}
Expand Down Expand Up @@ -335,7 +541,7 @@ func TestTalosClusterClient_ensureClient(t *testing.T) {
setup := func(t *testing.T) *TalosClusterClient {
t.Helper()
client := NewTalosClusterClient()
client.shims = setupShims(t)
client.shims = setupDefaultShims()
return client
}

Expand Down Expand Up @@ -419,7 +625,7 @@ func TestTalosClusterClient_getNodeHealthDetails(t *testing.T) {
setup := func(t *testing.T) *TalosClusterClient {
t.Helper()
client := NewTalosClusterClient()
client.shims = setupShims(t)
client.shims = setupDefaultShims()
return client
}

Expand Down Expand Up @@ -585,7 +791,7 @@ func TestTalosClusterClient_getNodeVersion(t *testing.T) {
setup := func(t *testing.T) *TalosClusterClient {
t.Helper()
client := NewTalosClusterClient()
client.shims = setupShims(t)
client.shims = setupDefaultShims()
return client
}

Expand Down Expand Up @@ -647,3 +853,41 @@ func TestTalosClusterClient_getNodeVersion(t *testing.T) {
}
})
}

// =============================================================================
// Test Shims
// =============================================================================

func TestNewShims(t *testing.T) {
t.Run("InitializesAllFields", func(t *testing.T) {
shims := NewShims()

if shims == nil {
t.Fatal("Expected non-nil Shims")
}

if shims.TalosConfigOpen == nil {
t.Error("Expected TalosConfigOpen to be initialized")
}

if shims.TalosNewClient == nil {
t.Error("Expected TalosNewClient to be initialized")
}

if shims.TalosVersion == nil {
t.Error("Expected TalosVersion to be initialized")
}

if shims.TalosWithNodes == nil {
t.Error("Expected TalosWithNodes to be initialized")
}

if shims.TalosServiceList == nil {
t.Error("Expected TalosServiceList to be initialized")
}

if shims.TalosClose == nil {
t.Error("Expected TalosClose to be initialized")
}
})
}
2 changes: 0 additions & 2 deletions pkg/provisioner/kubernetes/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ import (

// KubernetesClient defines methods for Kubernetes resource operations
type KubernetesClient interface {
// Resource operations
GetResource(gvr schema.GroupVersionResource, namespace, name string) (*unstructured.Unstructured, error)
ListResources(gvr schema.GroupVersionResource, namespace string) (*unstructured.UnstructuredList, error)
ApplyResource(gvr schema.GroupVersionResource, obj *unstructured.Unstructured, opts metav1.ApplyOptions) (*unstructured.Unstructured, error)
DeleteResource(gvr schema.GroupVersionResource, namespace, name string, opts metav1.DeleteOptions) error
PatchResource(gvr schema.GroupVersionResource, namespace, name string, pt types.PatchType, data []byte, opts metav1.PatchOptions) (*unstructured.Unstructured, error)
CheckHealth(ctx context.Context, endpoint string) error
// Node health operations
GetNodeReadyStatus(ctx context.Context, nodeNames []string) (map[string]bool, error)
}

Expand Down
Loading
Loading