fix(virt): Repair colima virtualization mode #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Colima virtualization mode was broken in the course of a recent refactor. This PR re-implements it correctly, fixing a number of issues, including: - Not resetting the session => incorrect `DOCKER_HOST` - Apply config faults in Configure in `pkg/project` - Adding `workstation.Prepare` to create sub-components after initial workstation construction Signed-off-by: Ryan VanGundy <85766511+rmvangun@users.noreply.github.com>
Signed-off-by: Ryan VanGundy <85766511+rmvangun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Colima virtualization mode was broken in the course of a recent refactor. This PR re-implements it correctly, fixing a number of issues, including:
DOCKER_HOSTpkg/projectworkstation.Prepareto create sub-components after initial workstation constructionSigned-off-by: Ryan VanGundy 85766511+rmvangun@users.noreply.github.com