Use CoreDNS in docker network and for node endpoints #981
+1,068
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Task linked: ENG-309 Use local coredns in docker network |
rmvangun
added a commit
that referenced
this pull request
Apr 23, 2025
* Use coredns for docker network * Don't assign localhost IPs to services * Always assign IP addresses to services * isLocalhost => isLocalhostMode * Use localhost IPs for corefile entries * Handles DNS appropriately * Fix linux test * Attempt linux fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we operate CoreDNS amongst our local development services, it seems reasonable to use it as our docker network DNS. This will eventually allow us to define hostnames and domain routing independently.
The code changes to make this possible are co-dependent on how we generate and template values in our default blueprints. As such, we now also use DNS names instead of IPs for looking up our nodes.