Skip to content

Conversation

@tvangundy
Copy link
Contributor

Add fluentbit support

@tvangundy tvangundy requested a review from Copilot March 29, 2025 19:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Fluentbit support for telemetry processing by introducing new kustomize components and configuration resources for systemd, kubernetes, containerd, and fluentd deployments.

  • Adds kustomize components and associated YAML files for different Fluentbit configurations.
  • Integrates Lua filters and custom metrics configuration for log processing.
  • Sets up helm and git repository resources to deploy the fluent-operator.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
kustomize/telemetry/resources/fluentbit/systemd/kustomization.yaml Adds systemd component with configuration references.
kustomize/telemetry/resources/fluentbit/systemd/fluentbit-clusterfilter.yaml Introduces a ClusterFilter using a Lua filter for systemd logs.
kustomize/telemetry/resources/fluentbit/systemd/configmap.yaml Provides a Lua script for timestamp formatting and log restructuring.
kustomize/telemetry/resources/fluentbit/kustomization.yaml Registers the fluentbit deployment resource.
kustomize/telemetry/resources/fluentbit/kubernetes/kustomization.yaml Adds kubernetes-level cluster input and filter components.
kustomize/telemetry/resources/fluentbit/kubernetes/fluentbit-clusterinput.yaml Defines a ClusterInput for retrieving container logs.
kustomize/telemetry/resources/fluentbit/kubernetes/fluentbit-clusterfilter.yaml Configures multiple filters for kubernetes logs including nesting and modifications.
kustomize/telemetry/resources/fluentbit/fluentd/kustomization.yaml Registers the fluentd component configuration.
kustomize/telemetry/resources/fluentbit/fluentd/clusteroutput.yaml Creates a ClusterOutput to forward logs to a fluentd endpoint.
kustomize/telemetry/resources/fluentbit/fluentbit.yaml Sets up the FluentBit deployment and its corresponding cluster configuration.
kustomize/telemetry/resources/fluentbit/containerd/* Provides containerd-specific components, including ClusterInput, ClusterFilter, and a ConfigMap with a Lua script.
kustomize/telemetry/base/fluentbit/* Adds base kustomization, helm repository, helm release, and git repository resources for deploying the fluent operator.
Comments suppressed due to low confidence (1)

kustomize/telemetry/base/fluentbit/helm-release.yaml:22

  • [nitpick] The key 'Kubernetes' is capitalized, which is inconsistent with typical YAML naming conventions; consider renaming it to 'kubernetes' for consistency.
    Kubernetes: false

key: containerd.lua
name: fluent-bit-containerd-config
timeAsTable: true
match: kube.*
Copy link

Copilot AI Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'match' value 'kube.' does not correspond to the input tag 'service.' defined in the corresponding ClusterInput, which may result in log filtering mismatches. Consider updating the match value to 'service.*' to ensure consistency.

Suggested change
match: kube.*
match: service.*

Copilot uses AI. Check for mistakes.
@rmvangun rmvangun added feature and removed chore labels Apr 6, 2025
@rmvangun rmvangun force-pushed the main branch 2 times, most recently from cffa994 to 3f24a5d Compare May 13, 2025 16:32
@rmvangun rmvangun force-pushed the main branch 12 times, most recently from 297a9cd to 9b7fcf8 Compare June 1, 2025 13:16
@rmvangun rmvangun merged commit a3308b3 into main Jul 8, 2025
5 checks passed
@rmvangun rmvangun deleted the fluentbit branch July 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants