Skip to content

store folder name to layer#16

Merged
mdorda merged 3 commits intowindycom:masterfrom
skydiablo:master
Mar 17, 2020
Merged

store folder name to layer#16
mdorda merged 3 commits intowindycom:masterfrom
skydiablo:master

Conversation

@skydiablo
Copy link
Copy Markdown
Contributor

No description provided.

@mdorda
Copy link
Copy Markdown
Contributor

mdorda commented Mar 13, 2020

Why do you need that? What does it fix?

@skydiablo
Copy link
Copy Markdown
Contributor Author

that allow me to add a kml with an layer-control with layer-name. by now, kml-folder-names are missing. or i'm wrong?

@skydiablo
Copy link
Copy Markdown
Contributor Author

skydiablo commented Mar 17, 2020

like this:

    fetch('URL')
        .then(res => res.text())
        .then(kmltext => {
            // Create new kml overlay
            const parser = new DOMParser();
            const kml = parser.parseFromString(kmltext, 'text/xml');
            const layers = new L.KML(kml);
            map.on('layeradd', eventLayerAdd);
            map.addLayer(layers);
        });

    const eventLayerAdd = function (e) {
        if (e.layer.options) {
            let name = e.layer.options.name;
            if (name) {
                if (!layerControl._getLayer(L.stamp(e.layer))) { //already added ?
                    layerControl.addOverlay(e.layer, name);
                }
            }
        }
    }

@mdorda
Copy link
Copy Markdown
Contributor

mdorda commented Mar 17, 2020

Ok, it makes sense. Thank you for the details. And the result from L.stamp cannot be used instead of the name?

@skydiablo
Copy link
Copy Markdown
Contributor Author

skydiablo commented Mar 17, 2020

the result from L.stamp is just a number, how do you want to get the name?

@mdorda
Copy link
Copy Markdown
Contributor

mdorda commented Mar 17, 2020

I mean, if you need just an identificator, L.stamp may work. But if you need (for some reason) name and nothing more than name, your merge request makes sense.

@skydiablo
Copy link
Copy Markdown
Contributor Author

on the other hand, is there any (for me unknown) workflow to get the folder-name from the KML?

@mdorda mdorda merged commit dfaa714 into windycom:master Mar 17, 2020
@skydiablo
Copy link
Copy Markdown
Contributor Author

skydiablo commented Mar 17, 2020

thx, in the near future, we should recheck this feature. so many other objects have an name tag. see reference, like:

  • Placemark
  • Folder
  • NetworkLink

so we can abstract this lines into a higher order to handle all of this objects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants