improve readme for people who are just getting started#1
Open
petergaultney wants to merge 1 commit intowingnut-tech:mainfrom
Open
improve readme for people who are just getting started#1petergaultney wants to merge 1 commit intowingnut-tech:mainfrom
petergaultney wants to merge 1 commit intowingnut-tech:mainfrom
Conversation
Contributor
|
Hey, thanks for the PR! Good catches on both the readme submodule instructions as well as mktemp. The build script was half for my own use for building/testing locally and half for the github workflow, so I hadn't worried a ton about portability before. One thing I noticed when trying the updated build script locally: now that it's using (also looks like something's up with the arduino-cli install script/their hosted files, and that's what caused the checks to fail when I tried just now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put some stuff in the README, but also made the build work on Mac by creating a temp directory from scratch rather than using a hardcoded one that only would work on Linux.
I didn't put a ton of thought into where this stuff should go in the README. I'm also not sure if the Arduino software is even required at this point - maybe we should note that it isn't if it's not?