Update to libavif 1.1.1 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh, the .github/ folder should probably be dropped. It is somewhat unfortunate, that libavif apparently doesn't ship release tarballs. |
Member
Author
I've disabled any actions for this repository; that should make further updates to libavif "easier". We can re-enable if there is the need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated to vanilla libavif 1.1.1, and patched to cater to our naming conventions (libavif_a.lib). A build (using https://github.com/winlibs/winlib-builder/tree/cmb/avif-111 and AOM v3.10.0) showed no issues when running the gd test suite, and would also resolve php/php-src#13919 (tested all three images).
Updating libavif for PHP 8.4 seems to be a no-brainer, but I'm not quite sure about PHP 8.2 and 8.3.
(And something to consider for the future: including AVIF support into GD drastically blew up the size of php_gd.dll; maybe that should be alleviated for those not requiring AVIF support at all. Especially considering that HEIF support might also be added, and maybe further image formats; thinking of JPEG XL. This is something to be catered to by php-src, but we would need to build shared libavif DLLs.)