Always pass a function to fs.close #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes DEP0013 in Node.js. Without this fix Winston would break in Node.js 10.
Contributor
Author
|
See nodejs/node#18668 for more details. |
Contributor
|
Dupe of #1207 |
Contributor
Author
|
This is not. v2.x needs to fixed. Also, this sets it to a noop, which might be more correct compared to the original code. |
Contributor
|
Oh, right. I missed the backport. Handling the error seems better out of my perspective. But that is not my call. |
Member
|
@BridgeAR "handling errors did seems better" was my initial reaction as well, but when I considered the semantics of the error (see: #1207 (comment)) this approach seemed more reasonable. |
indexzero
approved these changes
Mar 6, 2018
indexzero
added a commit
that referenced
this pull request
Mar 9, 2018
cjbarth
pushed a commit
to cjbarth/winston
that referenced
this pull request
Aug 22, 2018
* commit 'dc74db60b8d46475fce04bab1e0c31abe5201e09': (34 commits) [dist] Maintenance release. 2.4.3 [Winston 2.x] Decycle circular `Error` instances (winstonjs#1307) [dist] Maintenance release. 2.4.2 [dist] Add .gitattributes file. [fix] Backport winstonjs#1281 onto 2.x for maintenance. [dist] Add ignores from 3.x for easier maintenance switching. fix: clone() cloning prototype's custom methods (winstonjs#1086) Don't swallow Error message/stack when using formatter (winstonjs#1188) [dist] Add package-lock.json Update http.js - Add support for headers fix 2.x readme (fixes winstonjs#1179) [dist] Maintenance release. 2.4.1 Always pass a function to fs.close (winstonjs#1227) Update documentation for the `stringify` option [dist] Version bump. 2.4.0 [fix] Correct documentation mistake in 2.x Add how to colorize output in the custom formatter example (winstonjs#989) [fix] Container.add() 'filters' and 'rewriters' option passing to logger (winstonjs#1036) Fixed working of "humanReadableUnhandledException" parameter when additional data is added in meta (winstonjs#1066) Added filtering by log level (winstonjs#1040) ...
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes DEP0013 in Node.js.
Without this fix Winston would break in Node.js 10.