Added link to image resizing options#160
Added link to image resizing options#160LukeTowers merged 1 commit intowintercms:developfrom WebVPF:patch-1
Conversation
|
@mjauvin are you able to fix the linting errors or have they already been fixed on the develop branch? |
|
@LukeTowers from what I can see in the code, they have been fixed in develop. Furthermore, my last PR to the docs(#159) passed without those warnings. |
|
@WebVPF for future PRs to the docs, submit against the develop branch. |
|
@mjauvin I proceeded to edit from the link on the documentation page |
|
@LukeTowers @mjauvin there's a strange behavior with the documentation site. The link above have an anchor to Did one of you guys are in concern with it too ? |
|
@WebVPF right, ok. @bennothommo is that what we want or should we link to the develop branch ? |
Yeah, I've been noticing this as well. There's some magic happening while scrolling (this updates the anchor in the browser URL) and I think this is creating problems when first accessing the full URL that includes the anchor. @bennothommo any idea ? |
@mjauvin the intention was for the docs versions to match the Winter versions, so if the docs are for a fix/feature in the |
Yeah, I'm aware of that issue. I'll try and fix it today. |
|
@bennothommo were you able to fix the issue? |
|
@LukeTowers I have fixed the issue locally, but it relies on the PR to Winter to use the external Snowboard library, as the Nabu theme uses a custom app/Snowboard build. |
|
Can you ping me in whatever PRs need review for that again @bennothommo? |
|
@LukeTowers this one is the main one: wintercms/winter#980 |

Here in the table,
thumbOptionsparameter: https://wintercms.com/docs/v1.2/docs/backend/forms#file-uploadThe link goes here: https://wintercms.com/docs/v1.2/docs/services/image-resizing#available-parameters