Skip to content

Make extend() method usable with behaviors. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjauvin wants to merge 5 commits into from
Closed

Make extend() method usable with behaviors. #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8012b4
first draft to make extend() usable with behaviors
mjauvin Sep 8, 2022
8cb2f24
Clean up extendable trait, tweak property names
bennothommo Sep 8, 2022
0d9d3a8
Allow string to be provided for dynamic method callback
bennothommo Sep 8, 2022
f370220
Tweak API of model extension
bennothommo Sep 8, 2022
97112be
add unit tests for extend() method with $after argument
mjauvin Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Database/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ public function reloadRelations($relationName = null)
/**
* Extend this object properties upon construction.
*/
public static function extend(Closure $callback)
public static function extend(callable $callback, bool $after = false)
{
self::extendableExtendCallback($callback);
self::extendableExtendCallback($callback, $after);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/Extension/Extendable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public static function __callStatic($name, $params)
return self::extendableCallStatic($name, $params);
}

public static function extend(callable $callback)
public static function extend(callable $callback, bool $after = false)
{
self::extendableExtendCallback($callback);
self::extendableExtendCallback($callback, $after);
}
}
Loading